> On Apr 1, 2015, at 6:08 PM, James Peach <jpe...@apache.org> wrote: > > >> On Apr 1, 2015, at 3:50 PM, zw...@apache.org wrote: >> > [snip] >> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/26f438d4/proxy/http2/Http2SessionAccept.cc >> ---------------------------------------------------------------------- >> diff --git a/proxy/http2/Http2SessionAccept.cc >> b/proxy/http2/Http2SessionAccept.cc >> index 5fe2ce7..fbb25db 100644 >> --- a/proxy/http2/Http2SessionAccept.cc >> +++ b/proxy/http2/Http2SessionAccept.cc >> @@ -40,7 +40,7 @@ Http2SessionAccept::accept(NetVConnection *netvc, >> MIOBuffer *iobuf, IOBufferRead >> { >> // XXX we need to refactor the ACL checks from HttpSessionAccept so that we >> can invoke them here, and also in >> // the SPDY protocol layer ... >> - Warning("skipping access control checks for HTTP/2 connection"); >> + // Warning("skipping access control checks for HTTP/2 connection"); > > I added this warning so that someone would wire up the access control checks > for HTTP/2. I don't think we should remove the warning without doing that :)
I disagree, the Warning() makes the entire HTTP2 feature useless since it’ll fill up the disk :/. Feel free to make it a single warning on startup maybe ? — leif
