Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/616#discussion_r62196297
--- Diff: proxy/http/HttpConfig.h ---
@@ -363,27 +363,28 @@ struct OverridableHttpConfigParams {
: maintain_pristine_host_hdr(1), chunking_enabled(1),
negative_caching_enabled(0), negative_revalidating_enabled(0),
cache_when_to_revalidate(0), keep_alive_enabled_in(1),
keep_alive_enabled_out(1), keep_alive_post_out(1),
server_session_sharing_match(TS_SERVER_SESSION_SHARING_MATCH_BOTH),
auth_server_session_private(1),
- fwd_proxy_auth_to_parent(0), insert_age_in_response(1),
anonymize_remove_from(0), anonymize_remove_referer(0),
- anonymize_remove_user_agent(0), anonymize_remove_cookie(0),
anonymize_remove_client_ip(0), anonymize_insert_client_ip(1),
- proxy_response_server_enabled(1), proxy_response_hsts_max_age(-1),
proxy_response_hsts_include_subdomains(0),
- insert_squid_x_forwarded_for(1), send_http11_requests(1),
cache_http(1), cache_cluster_cache_local(0),
- cache_ignore_client_no_cache(1), cache_ignore_client_cc_max_age(0),
cache_ims_on_client_no_cache(1),
- cache_ignore_server_no_cache(0), cache_responses_to_cookies(1),
cache_ignore_auth(0), cache_urls_that_look_dynamic(1),
- cache_required_headers(2), cache_range_lookup(1),
cache_range_write(0), insert_request_via_string(1),
- insert_response_via_string(0), doc_in_cache_skip_dns(1),
flow_control_enabled(0), accept_encoding_filter_enabled(0),
- normalize_ae_gzip(0), negative_caching_lifetime(1800),
negative_revalidating_lifetime(1800), sock_recv_buffer_size_out(0),
- sock_send_buffer_size_out(0), sock_option_flag_out(0),
sock_packet_mark_out(0), sock_packet_tos_out(0),
- server_tcp_init_cwnd(0), request_hdr_max_size(131072),
response_hdr_max_size(131072), post_check_content_length_enabled(1),
- cache_heuristic_min_lifetime(3600),
cache_heuristic_max_lifetime(86400), cache_guaranteed_min_lifetime(0),
- cache_guaranteed_max_lifetime(31536000),
cache_max_stale_age(604800), keep_alive_no_activity_timeout_in(115),
- keep_alive_no_activity_timeout_out(120),
transaction_no_activity_timeout_in(30), transaction_no_activity_timeout_out(30),
- transaction_active_timeout_out(0), websocket_active_timeout(3600),
websocket_inactive_timeout(600), origin_max_connections(0),
- origin_max_connections_queue(0), attach_server_session_to_client(0),
connect_attempts_max_retries(0),
- connect_attempts_max_retries_dead_server(3),
connect_attempts_rr_retries(3), connect_attempts_timeout(30),
- post_connect_attempts_timeout(1800), down_server_timeout(300),
client_abort_threshold(10), freshness_fuzz_time(240),
- freshness_fuzz_min_time(0), max_cache_open_read_retries(-1),
cache_open_read_retry_time(10), cache_generation_number(-1),
- max_cache_open_write_retries(1), background_fill_active_timeout(60),
http_chunking_size(4096), flow_high_water_mark(0),
- flow_low_water_mark(0), default_buffer_size_index(8),
default_buffer_water_mark(32768), slow_log_threshold(0),
+ fwd_proxy_auth_to_parent(0), uncacheable_requests_bypass_parent(1),
insert_age_in_response(1), anonymize_remove_from(0),
+ anonymize_remove_referer(0), anonymize_remove_user_agent(0),
anonymize_remove_cookie(0), anonymize_remove_client_ip(0),
+ anonymize_insert_client_ip(1), proxy_response_server_enabled(1),
proxy_response_hsts_max_age(-1),
+ proxy_response_hsts_include_subdomains(0),
insert_squid_x_forwarded_for(1), send_http11_requests(1), cache_http(1),
+ cache_cluster_cache_local(0), cache_ignore_client_no_cache(1),
cache_ignore_client_cc_max_age(0),
+ cache_ims_on_client_no_cache(1), cache_ignore_server_no_cache(0),
cache_responses_to_cookies(1), cache_ignore_auth(0),
+ cache_urls_that_look_dynamic(1), cache_required_headers(2),
cache_range_lookup(1), cache_range_write(0),
+ insert_request_via_string(1), insert_response_via_string(0),
doc_in_cache_skip_dns(1), flow_control_enabled(0),
+ accept_encoding_filter_enabled(0), normalize_ae_gzip(0),
negative_caching_lifetime(1800),
+ negative_revalidating_lifetime(1800), sock_recv_buffer_size_out(0),
sock_send_buffer_size_out(0), sock_option_flag_out(0),
+ sock_packet_mark_out(0), sock_packet_tos_out(0),
server_tcp_init_cwnd(0), request_hdr_max_size(131072),
+ response_hdr_max_size(131072), post_check_content_length_enabled(1),
cache_heuristic_min_lifetime(3600),
+ cache_heuristic_max_lifetime(86400),
cache_guaranteed_min_lifetime(0), cache_guaranteed_max_lifetime(31536000),
+ cache_max_stale_age(604800), keep_alive_no_activity_timeout_in(115),
keep_alive_no_activity_timeout_out(120),
+ transaction_no_activity_timeout_in(30),
transaction_no_activity_timeout_out(30), transaction_active_timeout_out(0),
+ websocket_active_timeout(3600), websocket_inactive_timeout(600),
origin_max_connections(0), origin_max_connections_queue(0),
+ attach_server_session_to_client(0), connect_attempts_max_retries(0),
connect_attempts_max_retries_dead_server(3),
+ connect_attempts_rr_retries(3), connect_attempts_timeout(30),
post_connect_attempts_timeout(1800), down_server_timeout(300),
+ client_abort_threshold(10), freshness_fuzz_time(240),
freshness_fuzz_min_time(0), max_cache_open_read_retries(-1),
+ cache_open_read_retry_time(10), cache_generation_number(-1),
max_cache_open_write_retries(1),
+ background_fill_active_timeout(60), http_chunking_size(4096),
flow_high_water_mark(0), flow_low_water_mark(0),
+ default_buffer_size_index(8), default_buffer_water_mark(32768),
slow_log_threshold(0),
--- End diff --
Could you make a clang-format commit so that these are one element per
line. That would make it easier to read and diffs would be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
