Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/616#discussion_r62197664
--- Diff: proxy/http/HttpConfig.h ---
@@ -851,8 +852,8 @@ extern volatile int32_t icp_dynamic_enabled;
/////////////////////////////////////////////////////////////
inline HttpConfigParams::HttpConfigParams()
: proxy_hostname(NULL), proxy_hostname_len(0),
server_max_connections(0), origin_min_keep_alive_connections(0),
- max_websocket_connections(-1), disable_ssl_parenting(0),
enable_url_expandomatic(0), no_dns_forward_to_parent(0),
- uncacheable_requests_bypass_parent(1), no_origin_server_dns(0),
use_client_target_addr(0), use_client_source_port(0),
+ max_websocket_connections(-1), disable_ssl_parenting(0),
enable_url_expandomatic(0),
+ no_dns_forward_to_parent(0), no_origin_server_dns(0),
use_client_target_addr(0), use_client_source_port(0),
--- End diff --
Well we made compromises :)
Since the list is so long, can we make a similar change to the one you have
don't for array initializers:
```C
no_dns_forward_to_parent(0),
no_origin_server_dns(0),
use_client_target_addr(0),
use_client_source_port(0),
```
Not proposing a general change in standards, just making a special case for
this instance since it is so hard to read all the initializers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
