Hi folks, On 01.03.19 08:50, Georg Kallidis wrote: > Thanks, Thomas, I agree. > > The last battlefield would be commons, avalon almost done (both in Turbine > and Fulcrum) and slf4j already removed (for the latter log4j2 provides all > integrations: l->s, s->l).
Ok, I went through the code and removed all references to commons-logging. Also tried to use the log4j2 features where possible. I'm a bit opinionated with the Fulcrum components. These are Avalon components and Avalon provides its own log system. To be consistent, I'd prefer to keep it that way. Years ago, I spent quite some time to pull this straight in the first place (fulcrum-intake and fulcrum-security, maybe some more). I would not expect to find log entries from Avalon services outside the "avalon" tree. > But should we change all implementations (removing commons.logging) or use > the Commons Logging Bridge or both? ;-) Please review what I committed. Bye, Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
