Simon Laws wrote:
On Wed, Aug 19, 2009 at 9:06 AM, Simon Nash<[email protected]> wrote:
Simon Laws wrote:
...snip

1. Renamed contribution and launcher directories so that the words
 "contribution" and "launcher" don't appear in the directory name.

+1
2. Renamed maven artifacts to scatours-contribution-xxx and
 scatours-launcher-xxx, where xxx is the directory name.

+1
On reflection I think this can be improved by using scatours-xxx
for the contribution artifacts and scatours-launcher-xxx for the
launchers.  This means the contribution jar files produced by
maven will have names like scatours-introducing-tours.jar instead
of scatours-contribution-introducing-tours.jar.  This feels more
natural to me.


I prefer having the word contribution appear. I think this clearly
identified what is and what isn't a contribution.

Simon


I think all the jars should be contributions.  There's no need to
create jars for the launchers.  At the moment this is happening because
I don't know how to tweak maven to stop it.  (Any advice would be
welcomed!)  If all the jars are contributions, it seems redundant and
cumbersome for them all to have "contribution" in their names.

  Simon

Reply via email to