Simon Nash wrote:
Simon Laws wrote:
I think all the jars should be contributions. There's no need to
create jars for the launchers. At the moment this is happening because
I don't know how to tweak maven to stop it. (Any advice would be
welcomed!) If all the jars are contributions, it seems redundant and
cumbersome for them all to have "contribution" in their names.
Simon
I think that value of the inclusion of the word contribution is to the
new user who has no idea what a contribution is. For me the word
underlines that it's just a jar and, when you see the jar mentioned in
a launcher, you see immediately that it is loading contributions. For
those who are familiar with SCA and contributions it's no great burden
to have the word there.
Simon
OK, I'll leave it like this for now. I have applied the other
naming changes to the fullapp contributions and launchers under
revisions r808241 and r808245. There are other contributions
and launchers still left to do, and I intend to update these in
batches where each batch is a related chunk of code.
Here are the contributions and launchers I have updated:
contributions/car-contribution
contributions/common-contribution
contributions/creditcard-payment-jaxb-contribution
contributions/currency-contribution
contributions/flight-contribution
contributions/fullapp-bespoketrip-contribution
contributions/fullapp-currency-contribution
contributions/fullapp-frontend-contribution
contributions/fullapp-packagedtrip-contribution
contributions/fullapp-shoppingcart-contribution
contributions/fullapp-ui-contribution
contributions/hotel-contribution
contributions/payment-java-contribution
contributions/scatours-contribution
contributions/shoppingcart-contribution
contributions/travelcatalog-contribution
contributions/trip-contribution
contributions/tripbooking-contribution
launchers/fullapp-launcher
You can easily see which modules have been updated by looking at the
module directory names. If the directory name ends with "-contribution"
or "-launcher" it hasn't been updated yet, otherwise it has.
Simon
I have finished converting the remaining modules under contributions,
launchers, clients and services to the new naming conventions. I have
not touched the following modules which are not part of the build and
seem to be connected with 2.0:
contributions/creditcard-payment-dosgi-contribution
contributions/creditcard-payment-web-contribution
contributions/currency-converter-dosgi-contribution
The list of naming conventions that I sent previously did not include
anything for composite names. I found different styles in the code
and I have used the following approach:
Composite file names:
All lower case, can contain hyphens
Examples: payment, payment-client, blog-feed
Composite names:
camelCase with no initial capital
Examples: payment, paymentClient, blogFeed
I tested my changes and everything seems OK. There is a problem in
launchers/currency-converter that needs investigation, and I have
created TUSCANY-3277 to track this. I'm not sure whether this was
happening before I made my changes.
Simon
