On Wed, Jan 27, 2010 at 3:03 AM, ant elder <[email protected]> wrote: > > To help try to get this out quickly I've had a look right away. > There's one issue which i think does need to be fixed which is several > copies of Dojo have got included in the src distribution so the src > distro LICENSE is out of date. It looks like including Dojo is an > accident, probably as the build is putting it in src/main/resources > instead of target/ and that means when the src distro is built it got > included. >
AFAIK, we are only shipping dojo in web-javascript-dojo, which has proper LICENSE and NOTICE pieces from Dojo... and all other samples download dojo from ant script... having said that, if you know a particular place where this is happening, please let me know. > There's a few other things that could be fixed if there's a respin > though they're not strictly release blockers if they're not fixed: > > The binary distro license has the wrong jar version for several jars, > it should have: > asm-3.1.jar > lucene-core-2.9.1.jar > lucene-highlighter-2.9.1.jar > lucene-memory-2.9.1.jar > These were fixed by Simon in 903640. > There are some license headers missing reported in the rat report, eg > in hessian binding > > The site.xml is not signed in tuscany-sca-1.6-updatesite > > sample quote-xquery doesn't work and the chat sample webapp doesn't > work properly in IE. I've not tried all the other samples but the > other ones i tried worked ok. > Did they ever worked well in IE ? Were they working in 1.5.1 ? Just trying to identify if this is a regression or more like a cross-browser issue we haven't taken care in the past... > The list of changes in the CHNAGES file isn't very useful just > pointing to Tuscany root JIRA website. > > ...ant > On my todo list... Thanks for the feedback. -- Luciano Resende http://people.apache.org/~lresende http://lresende.blogspot.com/
