On Fri, Oct 1, 2010 at 8:45 AM, Florian MOGA <[email protected]> wrote:
> On Thu, Sep 30, 2010 at 12:15 PM, Florian MOGA <[email protected]> wrote: > >> It's been a full day since I've proposed the *-contribution renaming and >> no negative reactions so I'll proceed with doing the changes tomorrow >> morning. > > > I've completed the renaming of the contribution-* samples to > *-contribution. Some observations below: > > - store is a contribution? it uses impl.widget, is it a webapp as well? > > No i think this isn't a webapp, impl.widget works both in and out of a webapp and this store contribution is the not in a webapp case. > > - i see we have poms in each and every directory. do you find it better > having a single pom at the root level of the samples folder? are things > easier to maintain this way? > > My preference would be to just have the root sample pom.xml as that seems easier to maintain to me and it keeps the sub folders cleaner. > > - should artifact names reflect the directory name? > > I like that best yes. > > - does logging-scribe fit better into the applications or learning-more > section? > > I probably don't mind either way > > - moved helloworld-jms into a separate binding-jms folder. is there any > reason it was in implementation-web? > > It looks like learning-more\binding-jms\helloworld-contribution creates a webapp so thats incorrectly named, i guess it should be learning-more\binding-jms\helloworld-webapp > > - wouldn't implementation-extension fit better in a "extending-tuscany" > category? in time we'll also add this type of samples for bindings and > other > things and they'll be hard to find inside the learning-more folder... > > I've already moved that to an extending-tuscany folder now and added a binding extension sample. > > - what's the async folder? it's got modules-like pom and seems to > include a launcher... shouldn't the launcher get into running-tuscany and > the other one into getting-started as comments say it demonstrates > synchronous/asynchronous invocation? > > I'm going to defer commenting on this one to others for now as i'd need to go work out what its really trying to show an dhow best to do that > > - there are a number of samples which are not marked either as > contributions or webapps: maven-osgi-junit, distributed-osgi, > implementation-composite folder. Should these samples have "-contribution" > appended at the end? would that make the names unnecessarily long? > > I think the things in implementation-composite should be moved to getting started The OSGi ones are a bit tricky as they don't really match the new samples structure, maybe there should be a separate folder for OSGi in samples. ...ant
