snip...
>
>>
>> what's the async folder? it's got modules-like pom and seems to include a
>> launcher... shouldn't the launcher get into running-tuscany and the other
>> one into getting-started as comments say it demonstrates
>> synchronous/asynchronous invocation?
>
> I'm going to defer commenting on this one to others for now as i'd need to
> go work out what its really trying to show an dhow best to do that

It's just showing asyn operations. There's no need for a launcher in
here as it should work with any of the other lauchers (need to be
tests of course).

>
>>
>> there are a number of samples which are not marked either as contributions
>> or webapps: maven-osgi-junit, distributed-osgi, implementation-composite
>> folder. Should these samples have "-contribution" appended at the end? would
>> that make the names unnecessarily long?
>
> I think the things in implementation-composite should be moved to getting
> started

Moving one would be fine. Don't need both in getting started. I
suggest we leave the ws version in learning-more. I.e. you don't need
to show the user every combination in getting started. That's what
learning-more gives us the the opportunity to do.

>
> The OSGi ones are a bit tricky as they don't really match the new samples
> structure, maybe there should be a separate folder for OSGi in samples.

Why do you say that they don't match the structure? They are
contributions that can we started with (OSGi) launchers.

>
>    ...ant
>

Simon

-- 
Apache Tuscany committer: tuscany.apache.org
Co-author of a book about Tuscany and SCA: tuscanyinaction.com

Reply via email to