atoulme commented on a change in pull request #38: v5 UDP packet handling
URL: https://github.com/apache/incubator-tuweni/pull/38#discussion_r335447552
##########
File path:
devp2p/src/main/kotlin/org/apache/tuweni/devp2p/v5/packet/UdpMessage.kt
##########
@@ -0,0 +1,59 @@
+package org.apache.tuweni.devp2p.v5.packet
+
+import org.apache.tuweni.bytes.Bytes
+import org.apache.tuweni.crypto.SECP256K1
+import org.apache.tuweni.crypto.sodium.SHA256Hash
+import java.nio.ByteBuffer
+
+abstract class UdpMessage(
+ val src: Bytes,
+ val dest: Bytes
+) {
+
+ protected val VERSION: Int = 5
+
+ abstract fun encode(): ByteBuffer
+
+ companion object {
+
+ const val MAX_UDP_MESSAGE_SIZE = 1280
Review comment:
this constant is defined twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
