atoulme commented on a change in pull request #38: v5 UDP packet handling
URL: https://github.com/apache/incubator-tuweni/pull/38#discussion_r335446704
##########
File path:
devp2p/src/main/kotlin/org/apache/tuweni/devp2p/v5/internal/DefaultUdpConnector.kt
##########
@@ -0,0 +1,89 @@
+package org.apache.tuweni.devp2p.v5.internal
+
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.Job
+import kotlinx.coroutines.launch
+import org.apache.tuweni.bytes.Bytes
+import org.apache.tuweni.devp2p.v5.MessageHandler
+import org.apache.tuweni.devp2p.v5.PacketCodec
+import org.apache.tuweni.devp2p.v5.UdpConnector
+import org.apache.tuweni.devp2p.v5.internal.handler.RandomMessageHandler
+import org.apache.tuweni.devp2p.v5.internal.handler.WhoAreYouMessageHandler
+import org.apache.tuweni.devp2p.v5.packet.RandomMessage
+import org.apache.tuweni.devp2p.v5.packet.UdpMessage
+import org.apache.tuweni.devp2p.v5.packet.WhoAreYouMessage
+import org.apache.tuweni.net.coroutines.CoroutineDatagramChannel
+import java.net.InetSocketAddress
+import java.nio.ByteBuffer
+import kotlin.coroutines.CoroutineContext
+
+class DefaultUdpConnector(
+ private val nodeId: Bytes,
+ private val bindAddress: InetSocketAddress,
+ private val receiveChannel: CoroutineDatagramChannel =
CoroutineDatagramChannel.open(),
+ private val sendChannel: CoroutineDatagramChannel =
CoroutineDatagramChannel.open(),
+ private val packetCodec: PacketCodec = DefaultPacketCodec(nodeId),
+ override val coroutineContext: CoroutineContext = Dispatchers.IO
+): UdpConnector, CoroutineScope {
+
+ private val randomMessageHandler: MessageHandler<RandomMessage> =
RandomMessageHandler()
+ private val whoAreYouMessageHandler: MessageHandler<WhoAreYouMessage> =
WhoAreYouMessageHandler()
+
+ private val authenticatingPeers: MutableMap<InetSocketAddress, Bytes> =
mutableMapOf()
+
+ private lateinit var receiveJob: Job
+
+ override fun start(): Job {
+ receiveChannel.bind(bindAddress)
+
+ receiveJob = launch {
+ val datagram = ByteBuffer.allocate(MAX_PACKET_SIZE)
+ while (receiveChannel.isOpen) {
+ datagram.clear()
+ val address = receiveChannel.receive(datagram) as InetSocketAddress
Review comment:
What happens with the overflow bytes if any?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
