siladu opened a new issue, #448: URL: https://github.com/apache/incubator-tuweni/issues/448
I might be wrong but I believe toShortHexString contains a bug for the zero value. It's correct according to this test case but I'm not convinced the test case is correct: https://github.com/apache/incubator-tuweni/blob/ef737ec675997da710735e9b7acba87755f2a290/bytes/src/test/java/org/apache/tuweni/bytes/CommonBytesTests.java#L446 I would also argue that trimLeadingZeros should also return "0x0" for 0 since zero isn't a _leading_ zero. I came across this for UInt64 but may apply to other datatypes. Please could I get confirmation if this is a bug or not? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org For additional commands, e-mail: dev-h...@tuweni.apache.org
