siladu commented on issue #448: URL: https://github.com/apache/incubator-tuweni/issues/448#issuecomment-1323080935
> In RLP a UInt64 of 0 is actually a byte string (because RLP doesn't have numbers) so is serialised as 0x That's fair and I can see how toShortHexString might have different requirements depending on if you want to serialize to RLP or JSON. I would still argue trimLeadingZeros is either a misleading name or behaviour. Maybe it makes sense for the RLP scenario, but it could be more explicit about it in the name as for me that was unexpected behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tuweni.apache.org For additional commands, e-mail: dev-h...@tuweni.apache.org
