[ 
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566797#comment-15566797
 ] 

ASF GitHub Bot commented on TWILL-138:
--------------------------------------

Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r82901524
  
    --- Diff: 
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java
 ---
    @@ -17,26 +17,41 @@
      */
     package org.apache.twill.internal.container;
     
    +import ch.qos.logback.classic.Level;
    +import ch.qos.logback.classic.LoggerContext;
    +import com.google.common.base.Charsets;
     import com.google.common.base.Preconditions;
    +import com.google.common.io.Files;
    +import com.google.common.reflect.TypeToken;
     import com.google.common.util.concurrent.Futures;
     import com.google.common.util.concurrent.ListenableFuture;
     import com.google.common.util.concurrent.SettableFuture;
    +import com.google.gson.Gson;
     import org.apache.twill.api.Command;
     import org.apache.twill.api.RunId;
     import org.apache.twill.api.TwillRunnable;
     import org.apache.twill.api.TwillRunnableSpecification;
    +import org.apache.twill.api.logging.LogEntry;
     import org.apache.twill.common.Threads;
     import org.apache.twill.filesystem.Location;
     import org.apache.twill.internal.BasicTwillContext;
    +import org.apache.twill.internal.Constants;
     import org.apache.twill.internal.ContainerInfo;
     import org.apache.twill.internal.ContainerLiveNodeData;
     import org.apache.twill.internal.state.Message;
     import org.apache.twill.internal.utils.Instances;
    +import org.apache.twill.internal.utils.LogLevelUtil;
     import org.apache.twill.internal.yarn.AbstractYarnTwillService;
     import org.apache.twill.zookeeper.ZKClient;
    +import org.slf4j.ILoggerFactory;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    +import java.io.File;
    +import java.io.FileNotFoundException;
    +import java.io.IOException;
    +import java.io.Reader;
    --- End diff --
    
    Unused imports?


> Runtime change of Application runnable log level
> ------------------------------------------------
>
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to