ASF GitHub Bot commented on TWILL-138:

Github user chtyim commented on a diff in the pull request:

    --- Diff: 
    @@ -30,17 +34,33 @@
       private final int memoryMB;
       private final String host;
       private final Integer debugPort;
    -  private final Level logLevel;
    +  private final Map<String, LogEntry.Level> logLevels;
    +  private Level rootLogLevel;
    +  public DefaultTwillRunResources(int instanceId, String containerId, int 
cores, int memoryMB,
    --- End diff --
    Please add javadocs.

> Runtime change of Application runnable log level
> ------------------------------------------------
>                 Key: TWILL-138
>                 URL: https://issues.apache.org/jira/browse/TWILL-138
>             Project: Apache Twill
>          Issue Type: New Feature
>          Components: core
>            Reporter: Henry Saputra
> With TWILL-24 is supported for setting log level when starting the Twill 
> application, next enhancement is to able to send command to update the 
> aggregate log level for a particular runnable in a Twill application.

This message was sent by Atlassian JIRA

Reply via email to