Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/14#discussion_r83519511
  
    --- Diff: 
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java 
---
    @@ -90,8 +103,18 @@ public Integer getDebugPort() {
       }
     
       @Override
    +  @Deprecated
       public Level getLogLevel() {
    -    return logLevel;
    +    return getRootLogLevel();
    +  }
    +
    +  @Override
    +  public Level getRootLogLevel() {
    +    return getLogLevels().get(Logger.ROOT_LOGGER_NAME);
    +  }
    +
    +  public Map<String, LogEntry.Level> getLogLevels() {
    --- End diff --
    
    Add `@Override`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to