Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r86276202
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java
---
@@ -55,9 +58,11 @@ public JsonElement serialize(TwillRunResources src, Type
typeOfSrc, JsonSerializ
if (src.getDebugPort() != null) {
json.addProperty(DEBUG_PORT, src.getDebugPort());
}
- if (src.getLogLevel() != null) {
- json.addProperty(LOG_LEVEL, src.getLogLevel().toString());
+ if (src.getRootLogLevel() != null) {
--- End diff --
is this needed? It appears to me that the root log level is already in the
src.getLogLevels()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---