[ 
https://issues.apache.org/jira/browse/TWILL-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840821#comment-13840821
 ] 

Gary Helmling commented on TWILL-15:
------------------------------------

Thanks for the patch!  A couple of small comments...

{code}
-        os.close();
+        if (os != null) os.close();os.close();
{code}

Duplicate {{os.close;}} (which would also occur outside the if statement 
block).  Please remove.

{code}
+          } catch (IOException e) {
+            throw new IOException("failure copying from " + 
file.getAbsoluteFile() + " to JAR file emtry " + entry, e);
{code}

"emtry" -> "entry"

> Detailed error message when copy to HDFS fails
> ----------------------------------------------
>
>                 Key: TWILL-15
>                 URL: https://issues.apache.org/jira/browse/TWILL-15
>             Project: Apache Twill
>          Issue Type: Bug
>            Reporter: Bernd Fondermann
>         Attachments: TWILL-15-2.patch, TWILL-15.patch
>
>
> When the target dir in HDFS does not exist, or the ACLs don't allow write 
> access, the copy fails. The related message won't give details, so 
> troubleshooting is difficult.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to