[
https://issues.apache.org/jira/browse/TWILL-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841784#comment-13841784
]
Terence Yim commented on TWILL-15:
----------------------------------
Thanks Bernd for the fix. I do have one question and one style comment.
1. In
{code}
+ } catch (Throwable e) {
+ throw new IOException("failed to copy bundle from " + tmpJar.getName()
+ " to " + target.toURI(), e);
} finally {
{code}
should it be only catching IOException while letting other type of exceptions
to propagate? Catching Throwable means we are converting every exceptions into
IOException.
2. We haven't published code style guide yet, but for "if" condition, we always
write it on multiple lines with "{ }".
{code}
if (os != null) os.close();
{code}
Should be
{code}
if (os != null) {
os.close();
}
{code}
> Detailed error message when copy to HDFS fails
> ----------------------------------------------
>
> Key: TWILL-15
> URL: https://issues.apache.org/jira/browse/TWILL-15
> Project: Apache Twill
> Issue Type: Bug
> Reporter: Bernd Fondermann
> Attachments: TWILL-15-2.patch, TWILL-15-3.patch, TWILL-15.patch
>
>
> When the target dir in HDFS does not exist, or the ACLs don't allow write
> access, the copy fails. The related message won't give details, so
> troubleshooting is difficult.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
