[
https://issues.apache.org/jira/browse/TWILL-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529360#comment-14529360
]
ASF GitHub Bot commented on TWILL-69:
-------------------------------------
Github user henry-cask commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/32#discussion_r29717385
--- Diff:
twill-core/src/test/java/org/apache/twill/internal/ControllerTest.java ---
@@ -191,7 +186,7 @@ protected void triggerShutdown() {
}
private TwillController getController(ZKClient zkClient, RunId runId) {
- TwillController controller = new AbstractTwillController(runId,
zkClient, ImmutableList.<LogHandler>of()) {
+ AbstractTwillController controller = new
AbstractTwillController(runId, zkClient, ImmutableList.<LogHandler>of()) {
--- End diff --
Any reason why this change to AbstractTwillController?
> Remove guava dependencies on the twill-api and twill-common modules
> -------------------------------------------------------------------
>
> Key: TWILL-69
> URL: https://issues.apache.org/jira/browse/TWILL-69
> Project: Apache Twill
> Issue Type: Improvement
> Components: api
> Reporter: Terence Yim
> Fix For: 0.6.0-incubating
>
>
> Currently twill-api and twill-common has dependencies on guava (mainly for
> Service interface and some collection helpers). The dependencies could
> sometime causes conflicts to twill apps.
> By removing the guava dependencies from twill-api and twill-common, which are
> the only modules that twill app would depends on (not the client, but the
> implementation of TwillRunnable), together with the Bundled Jar support, one
> could easily write and run twill apps without worrying about dependencies
> conflict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
