[
https://issues.apache.org/jira/browse/TWILL-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529467#comment-14529467
]
ASF GitHub Bot commented on TWILL-69:
-------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/32#discussion_r29721597
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
@@ -408,26 +429,17 @@ public void cancel() {
}
private YarnTwillController listenController(final YarnTwillController
controller) {
- controller.addListener(new ServiceListenerAdapter() {
- @Override
- public void terminated(State from) {
- removeController();
- }
-
+ controller.onTerminated(new Runnable() {
@Override
- public void failed(State from, Throwable failure) {
- removeController();
- }
-
- private void removeController() {
+ public void run() {
synchronized (YarnTwillRunnerService.this) {
Iterables.removeIf(controllers.values(),
new Predicate<TwillController>() {
- @Override
- public boolean apply(TwillController input) {
- return input == controller;
- }
- });
+ @Override
--- End diff --
oops, probably done by the IDE automatically. Will fix it.
> Remove guava dependencies on the twill-api and twill-common modules
> -------------------------------------------------------------------
>
> Key: TWILL-69
> URL: https://issues.apache.org/jira/browse/TWILL-69
> Project: Apache Twill
> Issue Type: Improvement
> Components: api
> Reporter: Terence Yim
> Fix For: 0.6.0-incubating
>
>
> Currently twill-api and twill-common has dependencies on guava (mainly for
> Service interface and some collection helpers). The dependencies could
> sometime causes conflicts to twill apps.
> By removing the guava dependencies from twill-api and twill-common, which are
> the only modules that twill app would depends on (not the client, but the
> implementation of TwillRunnable), together with the Bundled Jar support, one
> could easily write and run twill apps without worrying about dependencies
> conflict.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
