Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/32#discussion_r29721551
--- Diff:
twill-core/src/test/java/org/apache/twill/internal/ControllerTest.java ---
@@ -191,7 +186,7 @@ protected void triggerShutdown() {
}
private TwillController getController(ZKClient zkClient, RunId runId) {
- TwillController controller = new AbstractTwillController(runId,
zkClient, ImmutableList.<LogHandler>of()) {
+ AbstractTwillController controller = new
AbstractTwillController(runId, zkClient, ImmutableList.<LogHandler>of()) {
--- End diff --
The actual instance is an instance of `AbstractTwillController`. For the
unit-test, we need to start the controller, which the start method only
available in the `AbstractTwillController`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
