Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/32#discussion_r29721597
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
@@ -408,26 +429,17 @@ public void cancel() {
}
private YarnTwillController listenController(final YarnTwillController
controller) {
- controller.addListener(new ServiceListenerAdapter() {
- @Override
- public void terminated(State from) {
- removeController();
- }
-
+ controller.onTerminated(new Runnable() {
@Override
- public void failed(State from, Throwable failure) {
- removeController();
- }
-
- private void removeController() {
+ public void run() {
synchronized (YarnTwillRunnerService.this) {
Iterables.removeIf(controllers.values(),
new Predicate<TwillController>() {
- @Override
- public boolean apply(TwillController input) {
- return input == controller;
- }
- });
+ @Override
--- End diff --
oops, probably done by the IDE automatically. Will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
