[
https://issues.apache.org/jira/browse/TWILL-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553401#comment-14553401
]
ASF GitHub Bot commented on TWILL-83:
-------------------------------------
Github user ghelmling commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/33#discussion_r30762921
--- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/BaseYarnTest.java
---
@@ -57,4 +78,25 @@ public final void cleanupTest() {
}
}
}
+
+ public <T> boolean waitForSize(Iterable<T> iterable, int count, int
limit) throws InterruptedException {
--- End diff --
Would help to add javadoc that max wait time is limit seconds
> distribute YarnTestUtils for easier downstream testing
> ------------------------------------------------------
>
> Key: TWILL-83
> URL: https://issues.apache.org/jira/browse/TWILL-83
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Reporter: Steve Loughran
> Assignee: Terence Yim
> Priority: Minor
> Labels: newbie
> Fix For: 0.6.0-incubating
>
>
> the {{YarnTestUtils}} class hides a lot of the work to get yarn mini clusters
> up and running for tests.
> it would be easier for downstream apps to use it if either the test jar were
> packaged for re-use, or better yet - the class was moved into the main yarn
> source package
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
