[
https://issues.apache.org/jira/browse/TWILL-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553414#comment-14553414
]
ASF GitHub Bot commented on TWILL-83:
-------------------------------------
Github user ghelmling commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/33#discussion_r30763394
--- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/TwillTester.java
---
@@ -37,67 +38,61 @@
import java.io.File;
import java.io.IOException;
import java.util.List;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicBoolean;
/**
- * Utilities for testing YARN.
+ * A TwillTester rule allows creation of mini Yarn cluster and {@link
TwillRunner} used for testing that is
+ * guaranteed to be teared down when tests are done.
+ *
+ * <pre>
+ * public class TwillTest {
+ * @ClassRule
+ * public static final TwillTester TWILL_TESTER = new TwillTester();
+ *
+ * @Test
+ * public void test() {
+ * TwillRunner twillRunner = TWILL_TESTER.getTwillRunner();
+ * twillRunner.prepare(...).start();
+ * }
+ * }
+ * </pre>
*/
-public final class YarnTestUtils {
--- End diff --
Is YarnTestUtils likely to be used by any current Twill users? Is so, it
would be better to deprecate it, and add TwillTest as a new class. This would
allow any potential users time to transition.
> distribute YarnTestUtils for easier downstream testing
> ------------------------------------------------------
>
> Key: TWILL-83
> URL: https://issues.apache.org/jira/browse/TWILL-83
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Reporter: Steve Loughran
> Assignee: Terence Yim
> Priority: Minor
> Labels: newbie
> Fix For: 0.6.0-incubating
>
>
> the {{YarnTestUtils}} class hides a lot of the work to get yarn mini clusters
> up and running for tests.
> it would be easier for downstream apps to use it if either the test jar were
> packaged for re-use, or better yet - the class was moved into the main yarn
> source package
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
