Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/49#discussion_r33111233
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/launcher/TwillLauncher.java ---
    @@ -138,7 +138,7 @@ private static void copy(InputStream is, File file) 
throws IOException {
         }
       }
     
    -  private static URLClassLoader createClassLoader(File dir, boolean 
useClassPath) {
    +  private static URLClassLoader createClassLoader(File dir, String 
classpathParam) {
    --- End diff --
    
    Should we check for null for the classpathParam ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to