Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-twill/pull/49#discussion_r33216752
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java 
---
    @@ -179,6 +179,20 @@
       TwillPreparer withClassPaths(Iterable<String> classPaths);
     
       /**
    +   * Includes the classes specified by yarn.application.classpath to the 
class loader
    +   * @return This {@link TwillPreparer}
    +   */
    +  TwillPreparer includeYarnApplicationClasspath();
    +
    +  /**
    +   * Excludes the classes matching the passed predicate from adding to the 
bundle jar for
    +   * ApplicationMaster and Container.
    +   * @param exclusionPredicate
    +   * @return This {@link TwillPreparer}
    +   */
    +  TwillPreparer withExclusionPredicate(Predicate<String> 
exclusionPredicate);
    --- End diff --
    
    Why just for exclusion? It should be for every class being inspected by the 
ApplicationBundler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to