Joerg Budischewski wrote:
Hi Stephan,
you can remove the runtime instances, they just cash some hashmap
lookups and have no side effects. The PyThreadAttach/Detach classes on
the other hand have side effects and cannot be removed.
Would be nice if you can execute the pyuno tests in
testtools/source/bridgetest/pyuno (at best before and ) after your
modifications. You currently need to set UNO_TYPES and UNO_SERVICES
environment variable to the values passed formerly by using the -env:
command line switches, just have a look in the makefile.
I'm too dumb to get that working, independent of the CWS changes. What
exactly do I need to do on a plain SRC680m130 to execute that test (on
Linux)?
-Stephan
Umn, I know, pyuno currently raises a lot of warnings, hope, you get
through though.
Good luck and bye,
Joerg
Stephan Bergmann wrote:
Friends and maintainers of pyuno, :)
Making our code base warning-clean (see thread on [email protected]),
I stumbled over a detail in pyuno/source/module/pyuno_module.cxx rev.
1.9.14.1 I am not sure how to resolve: The two functions PyEnum2Enum
and PyType2Type used to take a Runtime argument that they did not use,
so I removed it. However, in lines 458 and 483 of pyuno_module.cxx,
these functions got called with a freshly created Runtime instance:
{
Runtime runtime;
PyType2Type( obj, runtime );
}
and I am not sure whether the Runtime constructor should still be
called for side effects:
{
Runtime runtime;
PyType2Type( obj );
}
or whether that is not needed:
{
PyType2Type( obj );
}
-Stephan
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
