On 11/19/2011 12:33 PM, Marshall Schor wrote:
> On 11/18/2011 8:37 PM, Jörn Kottmann wrote:
>> I downloaded and verified the source release.
>> - NOTICE and LICENSE files are there.
>> - Build from source works
>>
>> The binary jars contain the LICENSE and NOTICE files
>> twice. Not sure why that is, maybe we want to fix this for
>> the next release. 
> The other copy is a ".vm" - a "velocity macro" template, that is part of the
> standard build tooling. 
>
>> The NOTICE file should say
>> "Apache UIMA uima-build-resources" instead of "UIMA uima-build-resources".
> The value of this comes from the project. name field - so to fix that, we need
> to change the line in the pom:
>
> <name>UIMA ${project.artifactId}</name>
>
> to
>
> <name>Apache UIMA ${project.artifactId}</name>, and while we're at it, 
> probably
> should check all the other POMs's names to see that they follow this 
> convention.

Or, we could leave the <name>s the same, and change the velocity macro for
NOTICE file, to add the "Apache" in front.

I did a scan of our projects, and we universally name things "UIMA xxxxx",
typically, UIMA xxx ${project.name}, e.g. UIMA Base uimaj-adapter-vinci Vinci
Adapter.

These names appear in the mvn command output - showing what's being built, and
in the Notice file.

I suggest we put a "conditional" in the velocity macro for generating Notice
files to do the logic: If the name starts with UIMA, then pre-pend Apache, while
leaving the rest of the names alone.

There's a downside to making the name that the mvn command prints longer - it
makes it a (little bit) harder to read.

WDYT?

-Marshall

>
> -Marshall
>> +1 to release
>>
>> Jörn
>>
>> On 11/18/11 10:06 PM, Marshall Schor wrote:
>>> This update is for these changes:
>>> https://issues.apache.org/jira/browse/UIMA/fixforversion/12317590
>>> Fixes intermittent docbook build issue and switches source-release packaging
>>> default to the standard apache way.
>>> Individual Jira links:
>>>    https://issues.apache.org/jira/browse/UIMA-2288
>>>    https://issues.apache.org/jira/browse/UIMA-2199
>>>
>>> The SVN tag is
>>> https://svn.apache.org/repos/asf/uima/build/tags/uima-build-resources-3/
>>>
>>> The artifacts (sources / jars) are here:
>>> https://repository.apache.org/content/repositories/orgapacheuima-220/
>>>
>>> Please vote on release:
>>>
>>> [ ] +1 OK to release
>>> [ ] 0   Don't care
>>> [ ] -1 Not ok to release, because ...
>>>
>>> After this, I will update the parent-pom to refer to the "released" version
>>> of this, and release it, so we can release the UIMA-SDK.
>>>
>>> -Marshall
>>>
>>>
>>

Reply via email to