Thanks Marshall for all your comments!
2013/6/20 Marshall Schor <[email protected]> > Hi, > > I see there are failures in the Jenkins build for add-ons... > > I think it is not right to change the 2.3.2-SNAPSHOT level of the > uima-addons > parent to 2.3.3-SNAPSHOT, since there was not a 2.3.2 release of this. > I was thinking to release the parent first, then some modules separately as 2.3.2 (e.g. Solrcas 2.3.2) and then an aggregate of all the modules which were released as 2.3.2 > > I'm not sure about some of the other changes to the addons-parent: > > The RAT configuration was removed; this will now inherit from the > uima-wide > parent. The difference in these is it is now missing the exclude for > ".idea/**" > - which I think is for the IntelliJidea development environment. This may > now > be a default exclude in RAT configuration anyways, so may not matter. > I'll check that. > > There is an added m2e lifecycle mapping which replicates one in the > common > uima-wide pom, for maven-dependency-plugin - so that should be removed > from this > pom. > ok > > There is a changed m2e lifecycle mapping for the uima-build-helper - the > change is it's marked ignore here, and in the common pom it's marked > execute. I > think this should be removed from the addons-parent and just inherit from > the > uima-wide parent. > ok > > If you agree with these changes to m2e configuration, I would remove the > entire configuration for m2e lifecycle from the addons-parent pom, and let > it > inherit from the uima-wide parent (5-SNAPSHOT, or 5, after the release is > voted > out). > yes, that sounds like the best option. > > I see you also removed the customized apache-release profile that was in > the > addons-parent. I think that may be the right thing to do, but we'll see > as we > go forward :-). > yes, I think that's bad to have different profiles with the same purpose and name that basically do the same things if not strictly needed. I'll rollback for now and do these changes. Regards, Tommaso > > -Marshall > > On 6/20/2013 10:51 AM, Tommaso Teofili wrote: > > Hi all, > > > > here's the first RC for uima-addons-parent 2.3.2. > > This version basically allows for better releasing individual addons > > modules by allowing specific jira versions (so it's a very trivial > change). > > > > Here's the SVN tag: > > http://svn.apache.org/r1495030 > > > > Here's the related fixed issue(s): > > > https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%20%222.3.2%20addons-parent%22%20AND%20project%20%3D%20UIMA > > > > The vote is open for next 72 hours. > > > > Regards, > > Tommaso > > > >
