[ 
https://issues.apache.org/jira/browse/UIMA-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743175#comment-13743175
 ] 

Richard Eckart de Castilho commented on UIMA-3097:
--------------------------------------------------

To sum up:
-1 IterablePipeline
0 PipelineIterable
0 JCasIterable 

JCasIterable and PipelineIterable end up on the same level. JCasIterable 
doesn't get any negative votes and incurs no change, so using that.

-3 .stepThroughPipeline
-1 .iteratePipeline
0 .iterate
-1 .stepPipeline

I note that iterate is possibly preferred for its conciseness, however, it has 
too high a risk of being ambigous when using static imports. The naming also is 
not in line with the other methods (runPipeline) or even methods of factories, 
which are called createXXX instead of just create. I'll revise my vote to +1 
iteratePipeline and choose that. Fortunately, this is not an official Apache 
voting process ;)
                
> Split JCasIterable into iterable and iterator parts
> ---------------------------------------------------
>
>                 Key: UIMA-3097
>                 URL: https://issues.apache.org/jira/browse/UIMA-3097
>             Project: UIMA
>          Issue Type: Improvement
>          Components: uimaFIT
>            Reporter: Richard Eckart de Castilho
>            Assignee: Richard Eckart de Castilho
>             Fix For: 2.0.0uimaFIT
>
>
> The JCasIterable is an Iterable and an Iterator at the same time. The 
> iterator() method returns just "this". This goes against the expectation that 
> an Iterable should return a fresh iterator when iterator() is called.
> JCasIterable should therefore be split. The JCasIterable should only be 
> creatable with descriptions.
> Calling iterator should create a new JCasIterator which then is based on 
> concrete reader and AE instances.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to