I'm cancelling the vote; my sadness is offset by Jerry's glee in finding yet
another issue (after I did the same for him on the first DUCC release :-) ).

This last failure is caused by too little testing, due to my making a static
*final* constant for the default concurrency level in the JCasHashMap, based on
the number of available cores.  I had tested this on machines with 8 and 32
availableProcessors(). Jerry ran on a machine with 4... which failed.  I'll
change this to a non-final value, and allow it to be set in the test case, so I
can exhaustively iterate through and test all values of this.

-Marshall

On 5/6/2014 12:47 PM, Jaroslaw Cwiklik wrote:
> Unzipped source on linux - OK
>
> Built from source - FAILED
> Looks like the JCasHashMapTest has a bug. This is the stack trace:
>
>    Running org.apache.uima.jcas.impl.JCasHashMapTest
> test JCasHashMap with 4 threads
> time for v1 20,000 is 12 ms
> time for v1 20,000 is 10 ms
> time for v1 20,000 is 6 ms
> time for v1 20,000 is 5 ms
> time for v1 20,000 is 5 ms
> test JCasHashMap with compare with 4 threads
> test JCasHashMap collide with 4 threadsJCasHashMapTest collide, found = 15,
> 15, 15, 15,
> JCasHashMapTest growth
> JCasHashMapTest: expected 64 or 128, but got 64, 32, 64, 64,
> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.627 sec
> <<< FAILURE! - in org.apache.uima.jcas.impl.JCasHashMapTest
> testGrowth(org.apache.uima.jcas.impl.JCasHashMapTest) Time elapsed: 0.033
> sec <<< FAILURE!
> junit.framework.AssertionFailedError
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.assertTrue(Assert.java:20)
> at junit.framework.Assert.assertTrue(Assert.java:27)
> at
> org.apache.uima.jcas.impl.JCasHashMapTest.testGrowth(JCasHashMapTest.java:337)
>
> [X] -1 Not OK to release
>
>
> On Sun, May 4, 2014 at 11:28 AM, Marshall Schor <[email protected]> wrote:
>
>> compare source-release with source tag OK
>>
>> build from sources -OK
>>
>> install from update site into Eclipse 4.3.2 - OK
>>
>> on unzipped bin distr: ran adjust examples paths and document analyzer - OK
>>
>> spot check of licenses - jar OK, bin - OK, source - OK
>>
>> spot check of Javadocs - OK
>>
>> [X] +1 OK to release
>>
>> -Marshall Schor
>>

Reply via email to