if, after fixing, the dd2spring tests are ok, then, no... not a blocker. This is what I would expect.
On the other hand, if there are are (new) bugs discovered in dd2spring, it would depend if the bugs were "impactful"... or just cosmetic... -M On 12/9/2016 10:16 AM, Jaroslaw Cwiklik wrote: > I never run this test. Buried in a place I did not expect a junit test. > Since this is broken, are you inclined to vote the RC2 down? > -jerry > > On Fri, Dec 9, 2016 at 9:47 AM, Marshall Schor <[email protected]> wrote: > >> These are the tests for dd2spring transform xslt code. >> >> They make use of the src/main/test/resources, also kept in this project. >> >> They could be moved, because these tests are testing artifacts whose >> source are >> in this project (dd2spring script). >> >> I think these were always run "by hand" (in Eclipse, right click the >> src/test/java folder and pick Run As junit test), whenever dd2spring >> changed. >> >> I traced the reason this compile error is occurring by looking at the SVN >> history of Dd2spring java source. There was a new "test mode" added to >> dd2spring back in 4 Feb 2015 (rev 1657361), which had this "setTestMode()" >> method. That was removed from dd2spring, breaking this test, on 21 July >> 2016, >> revision 1753681, perhaps accidentally. >> >> As I recall, the reason these tests were run manually was because they are >> thrown-together tests (better than nothing) that are rather fragile in how >> they >> compare results. (probably needs the new xml compare utility to avoid >> spurious >> complaints for instance due to <xyz></xyz> not comparing equal with >> <xyz/>). >> >> -Marshall >> >> On 12/9/2016 9:14 AM, Jaroslaw Cwiklik wrote: >>> Isn't this an odd place for a Junit test code? This fell off my radar >>> completely buried in this location. Don't recall placing this there. >> Seems >>> like this belongs to uimaj-as-activemq project where the rest of junit >>> tests for uima-as "live". What was the motivation to place this code in >> its >>> current location? This seems like dead code to me. Dead meaning not being >>> used. >>> >>> -jerry >>> >>> On Thu, Dec 8, 2016 at 4:17 PM, Marshall Schor <[email protected]> wrote: >>> >>>> In project uima-as, >>>> in the src/test/java, >>>> in the method org.apache.uima.as.dd, >>>> in the class Dd2SpringTest, there's a line: >>>> dd2SpringInstance.setTestMode(); // prevents throwing on >> errors >>>> which Eclipse flags as an error, because there is no "setTestMode()" >>>> method in >>>> Dd2SpringInstance. >>>> >>>> The normal maven build doesn't catch this because the project "uima-as" >> is >>>> not a >>>> configured as a Java project, >>>> so no compile of the src/test/java classes happens. >>>> >>>> Is this expected? >>>> >>>> -Marshall >>>> >>
