[
https://issues.apache.org/jira/browse/UIMA-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420555#comment-16420555
]
Richard Eckart de Castilho edited comment on UIMA-5753 at 3/30/18 2:31 PM:
---------------------------------------------------------------------------
We used this issue as an excuse to try out some of the social features of
GitHub, in particular the code review functionality:
https://github.com/apache/uima-uimaj/pull/1
The result is a patch against UIMA trunk (v2) offering the following changes:
* profile in the parent pom which activates on JDK 9+ and adds JAXB
dependencies in that case
* changes to two unit tests because when running the build on Java 9+, extra
line breaks are introduced into the XML files. In AnalysisEngine_ImplTest, the
issue is worked around by actually disabling pretty-printing in the serializer
- this causes the serialized result to match the expected result. In case of
the CasToInlineXmlTest, XmlUnit was advised to ignore the extra line breaks.
* Minor fixes to HTML tags in JavaDoc
Patch reflecting these changes is attached as
UIMA-5753--2018-03-30--1af71ac05a770d81cb053f4bf301ae25bd4dfcfd.patch
was (Author: rec):
We used this issue as an excuse to try out some of the social features of
GitHub, in particular the code review functionality:
https://github.com/apache/uima-uimaj/pull/1
The result is a patch against UIMA trunk (v2) offering the following changes:
* profile in the parent pom which activates on JDK 9+ and adds JAXB
dependencies in that case
* changes to two unit tests because when running the build on Java 9+, extra
line breaks are introduced into the XML files. In AnalysisEngine_ImplTest, the
issue is worked around by actually disabling pretty-printing in the serializer
- this causes the serialized result to match the expected result. In case of
the CasToInlineXmlTest, XmlUnit was advised to ignore the extra line breaks.
* Minor fixes to HTML tags in JavaDoc
> Get UIMA compile on Java 9 and higher
> -------------------------------------
>
> Key: UIMA-5753
> URL: https://issues.apache.org/jira/browse/UIMA-5753
> Project: UIMA
> Issue Type: Improvement
> Components: Core Java Framework
> Affects Versions: 2.10.2SDK
> Reporter: Richard Eckart de Castilho
> Assignee: Marshall Schor
> Priority: Minor
> Fix For: 3.0.1SDK, 2.10.3SDK
>
> Attachments:
> UIMA-5753--2018-03-30--1af71ac05a770d81cb053f4bf301ae25bd4dfcfd.patch
>
>
> Since meanwhile Java 10 has been released, seems like a good idea to get the
> build finally running on Java 9 and higher.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
