The xml descriptor differences that I remember involved some different treatment of white-space and new lines, when generating xml.
I think the errors involved test cases which were fixed by using some xml compare utility that had a parameter to relax the compare to allow for differences in whitespace / new lines. See for example: https://fisheye.apache.org/changelog/uimaj?cs=1843960 -Marshall On 11/7/2018 5:19 PM, Richard Eckart de Castilho wrote: > On 7. Nov 2018, at 22:00, Marshall Schor <[email protected]> wrote: >> I did a scan of uimaj code to see if we make use of the changed methods for >> ByteBuffer and didn't find any; so I'm inclined to *not* redo RC1 at this >> time. >> >> Let me know if you think I should redo it. > I tested against a locally built version of the RC source using JDK 11 - and > that did > not work out. > > I tested against a locally build version of the RC source using JDK 8 - that > seemed ok. > > I didn't yet test against the artifacts that you staged (which were built with > JDK 11 if I remember correctly). If they do not exhibit the problem, I'd say > we can go forward checking the RC. However, if they do exhibit the problem > and if they cannot be used in a Java 8 context, then I'd say we have to re-do > the RC. > > I'll keep you posted. > > Unrelated question: if I remember correctly, there were some tests involving > XML descriptors > where Java <= 8 and Java >= 9 produced slightly different XML files. (How) > did you fix these > cases when you enabled the successful build using Java 11? > > -- Richard
