mac-op commented on code in PR #25:
URL: https://github.com/apache/uima-uimacpp/pull/25#discussion_r1723708781
##########
src/test/data/descriptors/SimpleTextSegmenter.xml:
##########
@@ -32,7 +32,7 @@
<name>Simple Text Segmenter</name>
<description>
Splits a text document into pieces. The point at which the text
is split is determined by
- SegmentDelimiter configuration parameter which defaults to new
line ('\n').
+ SegmentDelimiter configuration parameter which defaults to '.'
Review Comment:
You're right it seems I don't remember my own code. I will revert it
##########
src/test/src/test_engine.cpp:
##########
@@ -635,9 +636,9 @@ void mainTest(uima::util::ConsoleUI & rclConsole,
testCallingSequence2(rclConsole, cpszConfigFilename);
testCallingSequence3(rclConsole, cpszConfigFilename);
}
- testCasMultiplier(rclConsole);
+ testCasMultiplier(rclConsole); testAggregateCASMultiplier(rclConsole);
+
#if 0
- testAggregateCASMultiplier(rclConsole);
testAggregateCASCombiner(rclConsole);
Review Comment:
I don't think nothing is missing in particular, this test case is just based
on a wrong assumption about as described in #24. The test case assumed the
ActionAfterCasMultiplier was DROP but it is actually DROP_IF_NEW_CAS_PRODUCED
by default, so I'm working on revising it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@uima.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
