mac-op commented on code in PR #25:
URL: https://github.com/apache/uima-uimacpp/pull/25#discussion_r1723729980
##########
src/framework/annotator_mgr.cpp:
##########
@@ -152,12 +155,21 @@ namespace uima {
assert(iv_vecEntries.empty());
AnnotatorContext & rANC = iv_pEngine->getAnnotatorContext();
-
AnalysisEngineDescription const & crTAESpecifier =
rANC.getTaeSpecifier(); // this method must be added
-
+ const AnalysisEngineMetaData* pEngineMetadata =
crTAESpecifier.getAnalysisEngineMetaData();
assert( ! crTAESpecifier.isPrimitive() );
- //BSIvector < icu::UnicodeString > const & crVecEngineNames =
crTAESpecifier.getAnalysisEngineMetaData()->getFixedFlow()->getNodes();
- vector < icu::UnicodeString > const & crVecEngineNames =
crTAESpecifier.getAnalysisEngineMetaData()->getFlowConstraints()->getNodes();
+
+ // FIXME: This shouldn't have been necessary since
FlowContrainst::getFlowContraintsType
Review Comment:
I meant the `FlowContrainst::getFlowContraintsType` method should have been
const because it doesn't change the object, so that we shouldn't have to do a
CONST_CAST, but that's just a mild annoyance I have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
