sergehuber commented on a change in pull request #131: Add the ability to
update event by item id
URL: https://github.com/apache/unomi/pull/131#discussion_r383095642
##########
File path:
services/src/main/java/org/apache/unomi/services/impl/events/EventServiceImpl.java
##########
@@ -250,6 +250,11 @@ private void getEventProperties(Map<String, Map<String,
Object>> mappings, List<
}
}
+ public boolean hasEventAlreadyBeenRaised(Event event) {
+ Event pastEvent = this.persistenceService.load(event.getItemId(),
Event.class);
Review comment:
Actually the hasEvent* methods are a known performance issue because they
perform searches over events which can be problematic for large event sets.
However, this implementation seems better since we are only searching for a
single event id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
