sergehuber commented on a change in pull request #131: Add the ability to 
update event by item id
URL: https://github.com/apache/unomi/pull/131#discussion_r383096052
 
 

 ##########
 File path: 
persistence-elasticsearch/core/src/main/resources/META-INF/cxs/mappings/rule.json
 ##########
 @@ -42,6 +42,9 @@
     },
     "raiseEventOnlyOnceForSession": {
       "type": "boolean"
+    },
 
 Review comment:
   I'm not sure how this modification would impact existing rule sets. Could 
you test this before and after adding this definition? If it fails this means a 
migration using the Migration commands will need to be implemented for this 
change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to