jkevan commented on a change in pull request #301:
URL: https://github.com/apache/unomi/pull/301#discussion_r635318998
##########
File path:
plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluator.java
##########
@@ -206,7 +206,7 @@ protected boolean isMatch(String op, Object actualValue,
String expectedValue, O
if (op == null) {
return false;
} else if (actualValue == null) {
- return op.equals("missing");
+ return op.equals("missing")|| op.equals("notIn") ||
op.equals("notEquals");
Review comment:
What happen if:
expectedValue: null
actualValue: null
op: notEquals
It's look like it will return true, but it should return false in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
