jkevan commented on a change in pull request #301:
URL: https://github.com/apache/unomi/pull/301#discussion_r691311060
##########
File path:
plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluator.java
##########
@@ -206,7 +206,7 @@ protected boolean isMatch(String op, Object actualValue,
String expectedValue, O
if (op == null) {
return false;
} else if (actualValue == null) {
- return op.equals("missing");
+ return op.equals("missing")|| op.equals("notIn") ||
op.equals("notEquals");
Review comment:
Thx for the clarification
##########
File path:
plugins/baseplugin/src/main/java/org/apache/unomi/plugins/baseplugin/conditions/PropertyConditionEvaluator.java
##########
@@ -206,7 +206,7 @@ protected boolean isMatch(String op, Object actualValue,
String expectedValue, O
if (op == null) {
return false;
} else if (actualValue == null) {
- return op.equals("missing");
+ return op.equals("missing")|| op.equals("notIn") ||
op.equals("notEquals");
Review comment:
But I also found this case that should be handle the same: 'hasNoneOf'
```suggestion
return op.equals("missing")|| op.equals("notIn") ||
op.equals("notEquals") || op.equals("hasNoneOf");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
