sergehuber commented on code in PR #754:
URL: https://github.com/apache/unomi/pull/754#discussion_r3252438090
##########
api/src/main/java/org/apache/unomi/api/Item.java:
##########
@@ -36,10 +40,10 @@
* though scopes could span across sites depending on the desired analysis
granularity). Scopes allow clients accessing the context server to filter data.
The context server
* defines a built-in scope ({@link Metadata#SYSTEM_SCOPE}) that clients can
use to share data across scopes.
*/
-public abstract class Item implements Serializable {
+public abstract class Item implements Serializable, YamlConvertible {
private static final Logger LOGGER =
LoggerFactory.getLogger(Item.class.getName());
- private static final long serialVersionUID = 7446061538573517071L;
+ private static final long serialVersionUID = 1217180125083162915L;
Review Comment:
Same rationale as for Parameter: added a brief comment that we do not rely
on Java serialization compatibility for Item across versions. The UID change
came with the broader API work in this PR; happy to revert to the previous UID
if PMC wants strict Serializable stability for these types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
