sergehuber commented on code in PR #754:
URL: https://github.com/apache/unomi/pull/754#discussion_r3252437580
##########
api/src/main/java/org/apache/unomi/api/Parameter.java:
##########
@@ -17,20 +17,27 @@
package org.apache.unomi.api;
+import org.apache.unomi.api.utils.YamlUtils;
+import org.apache.unomi.api.utils.YamlUtils.YamlConvertible;
+
import java.io.Serializable;
+import java.util.Map;
+import java.util.Set;
+
+import static org.apache.unomi.api.utils.YamlUtils.toYamlValue;
/**
* A representation of a condition parameter, to be used in the segment
building UI to either select parameters from a
* choicelist or to enter a specific value.
*/
-public class Parameter implements Serializable {
+public class Parameter implements Serializable, YamlConvertible {
Review Comment:
Unomi does not use Java serialization of these API DTOs as a cross-version
persistence contract (storage is JSON/OpenSearch, etc.). We kept the current
serialVersionUID and added a short class-level note to that effect. If the
project later standardizes on frozen UIDs for all Serializable API types, we
can align in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
