sergehuber commented on code in PR #764:
URL: https://github.com/apache/unomi/pull/764#discussion_r3315930471
##########
itests/src/test/java/org/apache/unomi/itests/PatchIT.java:
##########
@@ -49,7 +49,10 @@ public void testPatch() throws IOException {
profileService.refresh();
- newCompany = profileService.getPropertyType("company");
+ newCompany = keepTrying("Failed waiting for patched property type",
+ () -> profileService.getPropertyType("company"),
+ pt -> pt != null && "foo".equals(pt.getDefaultValue()),
+ DEFAULT_TRYING_TIMEOUT, DEFAULT_TRYING_TRIES);
Assert.assertEquals("foo", newCompany.getDefaultValue());
Review Comment:
Fixed — `testPatch()` already declares `throws IOException,
InterruptedException` in the current HEAD (added in the same commit that
introduced the `keepTrying` call). This comment is stale.
##########
itests/src/test/java/org/apache/unomi/itests/PatchIT.java:
##########
@@ -68,7 +71,10 @@ public void testOverride() throws IOException {
profileService.refresh();
- newGender = profileService.getPropertyType("gender");
+ newGender = keepTrying("Failed waiting for patched property type",
+ () -> profileService.getPropertyType("gender"),
+ pt -> pt != null && "foo".equals(pt.getDefaultValue()),
+ DEFAULT_TRYING_TIMEOUT, DEFAULT_TRYING_TRIES);
Assert.assertEquals("foo", newGender.getDefaultValue());
Review Comment:
Fixed — same as above, `testOverride()` already declares `throws
IOException, InterruptedException` in the current HEAD. This comment is stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
