sergehuber commented on code in PR #764:
URL: https://github.com/apache/unomi/pull/764#discussion_r3315932766
##########
build.sh:
##########
@@ -797,13 +817,22 @@ if [ "$USE_MAVEN_CACHE" = false ]; then
MVN_OPTS="$MVN_OPTS -Dmaven.build.cache.enabled=false"
fi
+# Extra Maven options (e.g. CI matrix ports: -Delasticsearch.port=9400)
+if [ -n "${MAVEN_EXTRA_OPTS:-}" ]; then
+ MVN_OPTS="$MVN_OPTS $MAVEN_EXTRA_OPTS"
+fi
Review Comment:
The unquoted expansion is intentional — `MVN_OPTS` is word-split when passed
to Maven (hence the `# shellcheck disable=SC2086` guards on those lines), so
`MAVEN_EXTRA_OPTS` must participate in that same split to land each `-D` flag
as a separate argument. In practice `MAVEN_EXTRA_OPTS` is set only by the CI
workflow YAML (port numbers), so values with internal whitespace aren't a real
concern today. A bash array would be the robust long-term fix if the variable
usage ever grows beyond simple `-Dkey=value` flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
