Github user tnine commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/112#discussion_r21212530
  
    --- Diff: 
stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/IndexingUtils.java
 ---
    @@ -151,69 +151,99 @@ public static XContentBuilder 
createDoubleStringIndexMapping(
     
                     .startObject( type )
     
    +                    // don't store source object in ES 
    +                    .field("_source") 
    --- End diff --
    
    I think we can easily write a migration to do this.  We already have the
    migration framework in place, we just need to write something that will
    iterate all apps and types, then update the mapping accordingly.  A lot of
    the functions have already been written, so we should be able to re-use
    them and just change our action for each entity type to update the mapping
    in ES..
    
    On Tue, Dec 2, 2014 at 8:09 PM, John Ament <notificati...@github.com> wrote:
    
    > In
    > 
stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/IndexingUtils.java:
    >
    > > @@ -151,69 +151,99 @@ public static XContentBuilder 
createDoubleStringIndexMapping(
    > >
    > >                  .startObject( type )
    > >
    > > +                    // don't store source object in ES
    > > +                    .field("_source")
    >
    > It looks like this branch would only be invoked if the index doesn't
    > exist. If you want to reapply mappings, you need to do something like
    >
    > esProvider.getClient().admin().indices().putMapping(new 
PutMappingRequest(indexName)
    > .source(XContentBuilder));
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-usergrid/pull/112/files#r21210325>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to