Github user tnine commented on a diff in the pull request:

    https://github.com/apache/incubator-usergrid/pull/112#discussion_r21380135
  
    --- Diff: 
stack/corepersistence/queryindex/src/main/java/org/apache/usergrid/persistence/index/impl/IndexingUtils.java
 ---
    @@ -151,69 +151,99 @@ public static XContentBuilder 
createDoubleStringIndexMapping(
     
                     .startObject( type )
     
    +                    // don't store source object in ES 
    +                    .field("_source") 
    --- End diff --
    
    I worry that this will cause an outage.  Since we don't have seek 
(Cassandra) vs search (Elasticsearch) in the v1 v2 bridge code sorted out, I'm 
concerned we'll get incorrect results.  What if we used Shawn's changes to add 
aliases and performed the following in our migration?
    
    
    1. Update the default mapping to your mapping
    1. Allocate a new index, and set the write alias to it
    1. Ensure the read alias points to old and new index
    1. Perform the current re-index operation, this will write all entities to 
the new index and create new mappings
    1. Delete the old index after the re-index is complete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to