Yeah that's weird. I guess grunt doesn't complain about missing files if they're not used?
On Tue Dec 16 2014 at 11:02:30 AM Shawn Feldman <[email protected]> wrote: > https://github.com/apache/incubator-usergrid/pull/124 > > On Tue Dec 16 2014 at 8:57:33 AM Shawn Feldman <[email protected]> > wrote: > > > here is the only reference i can find > > https://github.com/apache/incubator-usergrid/blob/ > master/portal/Gruntfile.js#L78 > > > > we can just remove that line > > > > On Tue Dec 16 2014 at 8:56:40 AM Shawn Feldman <[email protected]> > > wrote: > > > >> John do you see the file? all i can see is one line in the grunt file. > >> > >> On Tue Dec 16 2014 at 8:53:45 AM John D. Ament <[email protected]> > >> wrote: > >> > >>> From my point of view, you cannot create an apache release w/ this lib > in > >>> here. This was missed in the 1.0.0 release but that should not have > been > >>> releasable. > >>> > >>> On Tue Dec 16 2014 at 10:50:57 AM Shawn Feldman < > [email protected] > >>> > > >>> wrote: > >>> > >>> > i think we need to remove the lib, then remove the chart on the > >>> application > >>> > home page, then verify the tests pass > >>> > > >>> > On Tue Dec 16 2014 at 8:48:14 AM Dave Johnson <[email protected]> > >>> wrote: > >>> > > >>> > > We should definitely remove it and as soon as we can. I’d like to > >>> get an > >>> > > RC out for 1.0.1 today if possible. > >>> > > > >>> > > What needs to be done to remove it? > >>> > > > >>> > > - Dave > >>> > > > >>> > > > >>> > > > >>> > > > >>> > > > On Dec 16, 2014, at 10:30 AM, Shawn Feldman < > >>> [email protected]> > >>> > > wrote: > >>> > > > > >>> > > > We should probably remove it. It was used in our proprietary > >>> codebase > >>> > > and I > >>> > > > think only serves one chart on the application page > >>> > > > > >>> > > > On Tue, Dec 16, 2014, 7:11 AM John D. Ament < > [email protected] > >>> > > >>> > > wrote: > >>> > > > > >>> > > >> Hi, > >>> > > >> > >>> > > >> In the portal app, there's a dependency on Highcharts 2.3.5. As > >>> best > >>> > > as I > >>> > > >> can tell, this is a commercial license. > >>> http://www.highcharts.com/ > >>> > > >> > >>> > > >> Can you confirm this? > >>> > > >> > >>> > > >> John > >>> > > >> > >>> > > > >>> > > > >>> > > >>> > >> >
