On Fri Jan 02 2015 at 2:19:09 PM Dave Johnson <[email protected]> wrote:
> > > On Dec 29, 2014, at 9:49 AM, John D. Ament <[email protected]> > wrote: > > So I canceled the vote on your behalf on the general mailing list due to > > the licensing issues brought up by Justin. > > > > I did just open a PR to fix the binary file issue he found. > > https://github.com/apache/incubator-usergrid/pull/133 > > As a part of this, I also applied the ASF copyright headers to the files > in > > the repo. > > Awesome. Thanks John! I just accepted your PR. > > > > A few more questions remain. > > > > First, this file: > > https://github.com/apache/incubator-usergrid/blob/ > master/stack/launcher/src/main/java/org/apache/usergrid/launcher/ > ClasspathStaticHttpHandler.java > > Why is it GPL/CDDL? As best as I can tell it's unique to usergrid, I > > couldn't find it coming from one of the dependencies (e.g. Jersey). Is > it > > simply a header error? > > Perhaps some of the original Usergrid dev would know the answer. > > Ed, Nate and Todd… any ideas? > > > > Next is this file, which does appear to be copied. > > https://github.com/apache/incubator-usergrid/blob/ > master/stack/core/src/main/java/org/apache/usergrid/utils/BCrypt.java > > Can we instead depend on the jBCrypt library? It looks like it's in > maven: > > http://search.maven.org/#artifactdetails%7Corg.mindrot% > 7Cjbcrypt%7C0.3m%7Cjar <http://search.maven.org/# > artifactdetails|org.mindrot|jbcrypt|0.3m|jar> > > I don’t know the history there. If we switch to the library and the tests > still work, can we assume we are OK? > I was able to switch it out locally, delete the file, and import the class verbatim from their code. It seems to work fine, though I'm not sure where exactly you're using bcrypt. I can raise this as a PR as well if you want. > > > > The contents of the .NET SDK look like they just need to be listed in a > > NOTICE file, rather than the acknowledgements here: > > https://github.com/apache/incubator-usergrid/blob/ > master/sdks/dotnet/packages/NSubstitute.1.6.0.0/acknowledgements.txt > > That one sounds like an easy fix. > > Thanks again for the help on this, John. > > - Dave > >
