[
https://issues.apache.org/jira/browse/VCL-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032843#comment-14032843
]
ASF subversion and git services commented on VCL-702:
-----------------------------------------------------
Commit 1602979 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1602979 ]
VCL-702
Reworked new.pm::reserve_computer to not include OS-specific code. Moved some
of the old functionality to a new OS.pm::reserve subroutine. Updated reserve
subroutine in Linux.pm and Windows.pm.
Removed new.pm::confirm_public_ip_address. The functionality exists in
OS.pm::update_public_ip_address.
VCL-753
Added OS.pm::get_connect_method_remote_ip_addresses. Added Linux.pm:
get_user_remote_ip_addresses, get_port_connection_info.
VCL-564
Added OS.pm::run_scripts, which was formerly in Windows.pm. This isn't called
from anywhere yet.
Added $SOURCE_CONFIGURATION_DIRECTORY variable to Linux.pm.
VCL-253
Added Windows.pm::check_rdp_port_configuration. This is called from
Windows.pm::post_load. If the port number for the RDP connect method doesn't
match the registry it is configured.
> Rework code to use new subroutines and objects & general code cleanup
> ---------------------------------------------------------------------
>
> Key: VCL-702
> URL: https://issues.apache.org/jira/browse/VCL-702
> Project: VCL
> Issue Type: Improvement
> Components: vcld (backend)
> Affects Versions: 2.3
> Reporter: Andy Kurth
> Assignee: Andy Kurth
> Priority: Minor
> Fix For: 2.4
>
>
> There are various places in the code where some old code is being used which
> can be replaced with newer improved code. This issue is a catch-all for
> these.
> Examples:
> run_ssh_command -> $self->execute
> code_loop_timeout
> ALL PLACES WHERE 'GOTO' IS USED!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
